Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Custom Validator section to Validation docs #935

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Conversation

hsharghi
Copy link
Contributor

@hsharghi hsharghi commented Nov 6, 2023

Add a section about Custom Validators, and a sample to create a custom validator for zip codes. The sample is from a code that @0xTim had been provided in an issue.

Add 'How to create custom validators' to docs.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Few tweaks and then we're good

docs/basics/validation.md Outdated Show resolved Hide resolved
docs/basics/validation.md Outdated Show resolved Hide resolved
docs/basics/validation.md Outdated Show resolved Hide resolved
docs/basics/validation.md Outdated Show resolved Hide resolved
docs/basics/validation.md Outdated Show resolved Hide resolved
@hsharghi
Copy link
Contributor Author

hsharghi commented Nov 8, 2023

@0xTim Thanks for the suggestions. All done!

@hsharghi hsharghi requested a review from 0xTim November 8, 2023 19:50
docs/basics/validation.md Outdated Show resolved Hide resolved
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim enabled auto-merge (squash) November 9, 2023 12:23
@0xTim 0xTim merged commit 882b8a5 into vapor:main Nov 9, 2023
1 check passed
@penny-for-vapor penny-for-vapor bot mentioned this pull request Nov 9, 2023
9 tasks
@redsun redsun mentioned this pull request Nov 27, 2023
0xTim pushed a commit that referenced this pull request Dec 6, 2023
update cn doc for pr #935 

@Jinxiansen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants