-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese translation for ”basic" #948
Conversation
mkdocs.yml
Outdated
@@ -504,7 +505,7 @@ plugins: | |||
Getting Started: はじめに | |||
Install: インストール | |||
Legacy Docs: レガシードキュメント | |||
Logging: ロギング | |||
Logging: Logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want Japanese here instead of English?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xTim Can you clarify why ロギング wouldn't be the right choice here? The article reads "Vapor の Logging API は SwiftLog"; in both the original English text and the Japanese translation, "Logging" in this sentence is an uncountable noun, not a proper noun, despite the capitalization. As such, it seems to me that the Katakana form would be appropriate in the navigation, in the same way that インストール is used in place of "Install" a couple of lines further up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying it would be the right choice - the current PR replaces it in favour of an English title for the link which I think is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I misread the diff, I think 😵💫 But yeah, I agree, it should be a Japanese title (to the best of my understanding).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KaitoMuraoka let's keep it as is - it only affects the navigation links in the table of contents so it needs to be there in some form. Happy to have the Japanese title even if the page hasn't been translated yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide that this section should use the Katakana 'ロギング', then we should also translate other occurrences of 'Logging' as 'ロギング'. Additionally, 'Logger' should be translated as 'ロガー'.
Originally, I edited it to keep 'Logging' as is, thinking that it would be more intuitively understandable to Japanese speakers. However, upon reviewing other documents (such as the Python and Java documentation), I noticed that the Japanese translations use 'ロギング' and 'ロガー', so it might be better to unify these terms in Katakana.
Would this approach be acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
はい、それが最良の選択肢だと思います 👍
English
Yes, I think that is the best option 👍
@0xTim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Added Content
Added a Japanese translation of basics.
Also addressed Issue.: fb3b0c2
Japanese
## 追加内容basics の日本語訳を追加しました。