Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation for ”basic" #948

Merged
merged 19 commits into from
Nov 22, 2023

Conversation

KaitoMuraoka
Copy link
Contributor

@KaitoMuraoka KaitoMuraoka commented Nov 19, 2023

Added Content

Added a Japanese translation of basics.

Also addressed Issue.: fb3b0c2

Japanese ## 追加内容

basics の日本語訳を追加しました。

@KaitoMuraoka KaitoMuraoka marked this pull request as ready for review November 19, 2023 07:49
@KaitoMuraoka KaitoMuraoka requested review from a team, 0xTim and gwynne as code owners November 19, 2023 07:49
mkdocs.yml Outdated
@@ -504,7 +505,7 @@ plugins:
Getting Started: はじめに
Install: インストール
Legacy Docs: レガシードキュメント
Logging: ロギング
Logging: Logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want Japanese here instead of English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xTim

Thank you for pointing that out!
This time, I intend not to translate "Logging" into Japanese.
Therefore, I have deleted the relevant part.7e80d1c

Japanese

ご指摘ありがとう!
今回、"Logging" は日本語に翻訳しないつもりです。
そのため、該当箇所は削除しました。

Copy link
Member

@gwynne gwynne Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xTim Can you clarify why ロギング wouldn't be the right choice here? The article reads "Vapor の Logging API は SwiftLog"; in both the original English text and the Japanese translation, "Logging" in this sentence is an uncountable noun, not a proper noun, despite the capitalization. As such, it seems to me that the Katakana form would be appropriate in the navigation, in the same way that インストール is used in place of "Install" a couple of lines further up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm saying it would be the right choice - the current PR replaces it in favour of an English title for the link which I think is wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misread the diff, I think 😵‍💫 But yeah, I agree, it should be a Japanese title (to the best of my understanding).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaitoMuraoka let's keep it as is - it only affects the navigation links in the table of contents so it needs to be there in some form. Happy to have the Japanese title even if the page hasn't been translated yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xTim

If we decide that this section should use the Katakana 'ロギング', then we should also translate other occurrences of 'Logging' as 'ロギング'. Additionally, 'Logger' should be translated as 'ロガー'.

Originally, I edited it to keep 'Logging' as is, thinking that it would be more intuitively understandable to Japanese speakers. However, upon reviewing other documents (such as the Python and Java documentation), I noticed that the Japanese translations use 'ロギング' and 'ロガー', so it might be better to unify these terms in Katakana.

Would this approach be acceptable?

Japanese

この箇所がカタカナの「ロギング」であるべきとすると、他の箇所の「Logging」も「ロギング」に翻訳すべきと思います。また、「Logger」も「ロガー」と翻訳すべきと私は思います。

元々、私は「Logging」を「Logging」と表記した方が日本語話者に直感的に理解してもらえると思い編集しました。
しかし、他のドキュメント(例えばPythonJavaなど)を見ると日本語訳は「ロギング」、「ロガー」であることを見つけたのでカタカナで統一した方が良いかもしれません。

この方針で問題ないでしょうか?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、それが最良の選択肢だと思います 👍

English Yes, I think that is the best option 👍

@KaitoMuraoka
Copy link
Contributor Author

KaitoMuraoka commented Nov 20, 2023

@0xTim
I have edited it.
Please review it again! 🙏

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit 40a7eea into vapor:main Nov 22, 2023
1 check passed
@penny-for-vapor penny-for-vapor bot mentioned this pull request Nov 22, 2023
9 tasks
@KaitoMuraoka KaitoMuraoka deleted the feature/japanese-basic branch November 22, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants