Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation for Websockets.md #969 #968 #974

Merged
merged 20 commits into from
Jun 5, 2024

Conversation

TillTHMAcc
Copy link
Contributor

translation-update

@TillTHMAcc TillTHMAcc requested a review from a team as a code owner April 25, 2024 17:56
@0xTim 0xTim added the translation-update This PR contains translations for the docs label Apr 26, 2024
@mattesmohr
Copy link
Sponsor Member

@TillTHMAcc Hi, thanks for the contribution. How do you want to do the review? In German or in English?

@TillTHMAcc
Copy link
Contributor Author

@TillTHMAcc Hi, thanks for the contribution. How do you want to do the review? In German or in English?

German is good.

@ptoffy
Copy link
Member

ptoffy commented May 15, 2024

@mattesmohr any updates on this?

@mattesmohr
Copy link
Sponsor Member

@mattesmohr any updates on this?

I will do it tonight.

Copy link
Sponsor Member

@mattesmohr mattesmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der erste Schwung. @ptoffy Kannst ja mal drüberlesen. Vielleicht war ich zu kritisch. Habe auch ein paar Kommentare dazu geschrieben.

docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
TillTHMAcc and others added 8 commits May 16, 2024 09:24
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
@TillTHMAcc
Copy link
Contributor Author

Ich habe die letzten Sachen berichtigt

@mattesmohr
Copy link
Sponsor Member

Danke dir. Bin noch derzeit im Urlaub.

Copy link
Sponsor Member

@mattesmohr mattesmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Github don't let me do any more reviews and I am not sure why. Therefore I approve the PR.

Copy link
Sponsor Member

@mattesmohr mattesmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the last ones. Then, I think, we are good to go.

docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
docs/advanced/websockets.de.md Outdated Show resolved Hide resolved
TillTHMAcc and others added 6 commits June 5, 2024 10:31
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Co-authored-by: Mattes Mohr <mail@mattesmohr.de>
Copy link
Sponsor Member

@mattesmohr mattesmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattesmohr mattesmohr merged commit ae3add1 into vapor:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation-update This PR contains translations for the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants