Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around dependency conflict in latest DNSClient #59

Merged
merged 1 commit into from
May 18, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 18, 2023

Pins DNSClient to a version that doesn't exhibit the conflict for now.

…orking version via a fake dependency. Requires a MongoKitten with an updated dependency URL.
@gwynne gwynne added the semver-patch Internal changes only label May 18, 2023
@gwynne gwynne requested review from Joannis and 0xTim May 18, 2023 07:40
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the hassle!

@codecov-commenter
Copy link

Codecov Report

Merging #59 (bbafd45) into main (6129661) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files          20       20           
  Lines         686      686           
=======================================
  Hits          498      498           
  Misses        188      188           

@gwynne gwynne merged commit a4237b9 into main May 18, 2023
8 checks passed
@gwynne gwynne deleted the fix-dependency-conflict-in-dnsclient branch May 18, 2023 09:00
@VaporBot
Copy link

These changes are now available in 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants