Allow to create model with pre-given UUID idKey #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated PR description and created related issue. |
addisonwebb
reviewed
Jul 25, 2018
There was a problem hiding this comment.
This fix looks good to me. My only suggestion would be to add some tests here to protect against regressions. I had a nearly identical PR that was closed for some reason and I had some tests that might provide a good starting point. f7b068d
|
Hey @MihaelIsaev, you just merged a pull request, have a coin! You now have 84 coins. |
|
Thanks @tanner0101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When I'm trying to save model to the database with specified UUID ID it saves with another random UUID ID.
Why I need this fix
I'm trying to transfer data from another database and I really need to use my old UUIDs as PRIMARY KEY ID.
Workaround
We should check if UUID ID is already specified and only in case when it isn't fluent should generate random UUID.