This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Make the HTTPMessageDecoder.decode extension method public
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner0101
reviewed
Apr 2, 2019
There was a problem hiding this comment.
LGTM. We should also port this to Vapor 4.
https://github.com/vapor/http/blob/master/Sources/HTTPKit/Content/HTTPMessageDecoder.swift#L48
|
It seems to already be public there, that's why I didn't file a second PR.
… On 2. Apr 2019, at 21:55, Tanner ***@***.***> wrote:
@tanner0101 commented on this pull request.
LGTM. We should also port this to Vapor 4.
https://github.com/vapor/http/blob/master/Sources/HTTPKit/Content/HTTPMessageDecoder.swift#L48
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Renamed |
|
Hey @MrMage, you just merged a pull request, have a coin! You now have 21 coins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for decoding the JSON API media type (see https://jsonapi.org/format/). (Requires vapor/core#202.)