add curve and parameters properties to ECDSAKey protocol #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 69.05% 69.05%
=======================================
Files 59 59
Lines 1561 1561
=======================================
Hits 1078 1078
Misses 483 483
|
|
@JaapWijnen yeah looks like this isn't you, the same error is happening all over Vapor repos. There's probably something wrong with GH's CI or similar |
ptoffy
requested changes
Mar 14, 2024
There was a problem hiding this comment.
While we're making these public, could you please move tests such as https://github.com/vapor/jwt-kit/blob/main/Tests/JWTKitTests/InternalTests.swift#L7 to the ECDSATests file so we can minify internal tests as much as possible? Thanks!
ptoffy
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds curve and parameter properties to the ECDSAKey protocol and also makes them public (non settable) on the ECDSA.PublicKey and ECDSA.PrivateKey types.