Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created JWTSigner.verify(_:header:payload:) method #109

Closed
wants to merge 1 commit into from
Closed

Created JWTSigner.verify(_:header:payload:) method #109

wants to merge 1 commit into from

Conversation

calebkleveter
Copy link
Member

No description provided.

@calebkleveter calebkleveter added the enhancement New feature or request label Nov 6, 2019
@calebkleveter calebkleveter self-assigned this Nov 6, 2019
tanner0101
tanner0101 reviewed Dec 5, 2019
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind this additional public API?

This logic should probably also be shared with JWT.init(from:verifiedBy:) to prevent code dupe.

@grosch
Copy link
Contributor

grosch commented Apr 17, 2020

@calebkleveter Is this still necessary? Can you update or close please? Thanks.

@calebkleveter
Copy link
Member Author

@grosch No, I don't think this is needed anymore.

@ptoffy ptoffy deleted the signer-verify branch February 27, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 left review comments

Assignees

@calebkleveter calebkleveter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebkleveter @grosch @tanner0101