Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift 5 crash fix #34

Merged
merged 4 commits into from
Apr 10, 2019
Merged

swift 5 crash fix #34

merged 4 commits into from
Apr 10, 2019

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Apr 10, 2019 •
edited
Loading

  • Removes retention of a withUnsafeBytes buffer after the closure has expired. This causes reliable crashes in Swift 5, and could crash in Swift 4.
  • Moves to using Data.Index for storing position in Data, instead of Int.
  • Moves away from overflow ignoring (&+) operators.

@tanner0101 tanner0101 added the bug Something isn't working label Apr 10, 2019
@tanner0101 tanner0101 mentioned this pull request Apr 10, 2019
Closed
@tanner0101 tanner0101 merged commit f919a01 into master Apr 10, 2019
@penny-coin
Copy link

Hey @tanner0101, you just merged a pull request, have a coin!

You now have 1184 coins.

@tanner0101 tanner0101 deleted the swift-5-crash branch April 10, 2019 15:53
@terwanerik terwanerik mentioned this pull request Apr 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanner0101 @penny-coin