Add hostname to MySQLConnection.connect()

[programVeins]

Prior to this, hostname in MySQLConnection.connect() was optional and defaulted to nil. This resulted in an error where upon entering url for connection string, apple's swift-nio-ssl threw: NIOSSLExtraError.failedToValidateHostname: Couldn't find <none> in certificate from peer By adding hostname from user given configuration, this is fixed.

Fixes #311

[gwynne]

This will probably all get overhauled when I finish reworking MySQLNIO, but there's no reason not to have this fix in the meantime 👍

[codecov-commenter]

Codecov Report

Merging #317 (f0cceac) into main (6245a07) will increase coverage by 0.96%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   57.55%   58.52%   +0.96%     
==========================================
  Files           8        8              
  Lines         344      352       +8     
==========================================
+ Hits          198      206       +8     
  Misses        146      146              

Impacted Files	Coverage Δ
Sources/MySQLKit/MySQLConfiguration.swift	26.15% <100.00%> (+8.91%)	⬆️
Sources/MySQLKit/MySQLConnectionSource.swift	95.23% <100.00%> (+0.23%)	⬆️

[0xTim]

It's always macOS 😒

[gwynne]

Revised approval - the existing fix was incomplete due to missing logic for handling IP addresses correctly in the presence of a TLS configuration. The in-progress rewrite of MySQLNIO includes correct handling of the issue, but rather than make this wait another month for that, I tacked on a temporary fix in MySQLConfiguration.

Note: The fix is based on the code for handling the same concern in PostgresNIO, with the usual shoutout to @fabianfett for his fantastic work therein, of course! Even if it is a bit annoying to have to drop down to the POSIX API this way just 'cause NIOBSDSocket.inet.pton() isn't public... right, Fabian? 😉

Edit: For context, the macOS tests were previously failing due to a thrown NIOSSLExtraError.invalidSNIHostname when a hostname string contained an IP address (in this case 127.0.0.1); the issue was not macOS-specific, it just manifested there as a side effect of how the CI is set up.

[VaporBot]

These changes are now available in 4.6.2