Avoid double-logging queries #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoffy
previously approved these changes
May 28, 2024
MahdiBM
reviewed
May 28, 2024
MahdiBM
previously approved these changes
May 28, 2024
gwynne
force-pushed
the
remove-excess-query-logging
branch
from
3de6b4c
to
cd2f1de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 44.94% 44.09% -0.85%
==========================================
Files 38 38
Lines 3271 3218 -53
==========================================
- Hits 1470 1419 -51
+ Misses 1801 1799 -2
|
gwynne
force-pushed
the
remove-excess-query-logging
branch
from
cd2f1de
to
545b4c3
Compare
0xTim
reviewed
May 29, 2024
0xTim
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.7.2
This logging is handled in MySQLKit and should not be present at the MySQLNIO layer.