-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty keyed encoding #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change, thank you. This is a much better approach.
@@ -332,6 +332,12 @@ class PostgreSQLConnectionTests: XCTestCase { | |||
print(row) | |||
} | |||
|
|||
func testRowCodableEmptyKeyed() throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to the allTests
array at the bottom of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I always forget allTests
. Fixed.
…ner is requested The encoder will fallback to JSONB using JSONEncoder even if the encoded type does not encode any key.
Thanks :) |
Hey @baarde, you just merged a pull request, have a coin! You now have 8 coins. |
This fixes #122.