Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PostgresCastingError and make public #278

Closed
fabianfett opened this issue Apr 25, 2022 · 1 comment
Closed

Rename PostgresCastingError and make public #278

fabianfett opened this issue Apr 25, 2022 · 1 comment
Assignees
@fabianfett
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fabianfett
Copy link
Collaborator

fabianfett commented Apr 25, 2022 •
edited
Loading

  1. Checkout the code base
  2. Rename PostgresCastingError to PostgresDecodingError
  3. Make PostgresDecodingError public
  4. Make PostgresDecodingError.Code public
  5. Make the static properties on PostgresDecodingError.Code public
  6. Make the properties on PostgresDecodingError public
  7. Write an extension to PostgresDecodingError that conforms to CustomStringConvertible, move the description property there.
  8. Write a test that checks, if the description is always displayed as "Database error".
  9. Create a Pull Request

If you need any help, please let us know!
@fabianfett fabianfett added the enhancement New feature or request label Apr 25, 2022
@fabianfett fabianfett changed the title Make PostgresCastingError public Rename PostgresCastingError and make public Apr 25, 2022
@fabianfett fabianfett added the good first issue Good for newcomers label Apr 25, 2022
@nicholas-otto nicholas-otto mentioned this issue Apr 26, 2022
Closed
@fabianfett fabianfett self-assigned this Apr 26, 2022
@fabianfett
Copy link
Collaborator Author

Marked this issue as a assigned to me to move it to In Progress. I can not tag @nicholas-otto.

This was referenced Apr 26, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianfett fabianfett

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabianfett