Support non Foundation JSON coders #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a `PostgresJSONEncoder` protocol with an API that mirrors the Foundation `JSONEncoder`'s decoding function * add global `_defaultJSONEncoder` variable used in the JSON and JSONB type and that is defaulted to a Foundation `JSONEncoder` * add a `PostgresJSONDecoder` protocol with an API that mirrors the Foundation `JSONDecoder`'s decoding function * add global `_defaultJSONDecoder` variable used in the JSON and JSONB type and that is defaulted to a Foundation `JSONDecoder`
tanner0101
reviewed
Sep 2, 2020
There was a problem hiding this comment.
Code changes LGTM. This is a good compromise for the time being. A few things:
1: Add a test so we can make sure this works and doesn't get accidentally removed or broken in the future. This should set the static var back to normal after to not affect other tests.
2: Update PR body with a summary for release notes: https://github.com/vapor/vapor/blob/master/.github/contributing.md#releases
3: A docblock where _defaultJSON{Decoder,Encoder} is defined explaining what it does and to care for thread safety would be nice.
|
@tanner0101 Closing this and reopened on #127, for some reason this PR's branch name "no-currentIndex-increment..." got messed up no idea why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom, non-Foundation, JSON encoder and decoder through global variables
PostgresNIO._defaultJSONEncoderandPostgresNIO._defaultJSONDecoder(#125, fixes #126).