Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unintended SASL print statement #139

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Remove unintended SASL print statement #139

merged 1 commit into from
Feb 12, 2021

Conversation

fabianfett
Copy link
Collaborator

We currently print the internal SASL state when authenticating via SCRAM-SHA256. This messes up logs and is a potential security issue.

Modifications

  • Remove a print statement

@gwynne gwynne self-assigned this Feb 12, 2021
@gwynne gwynne added bug Something isn't working semver-patch labels Feb 12, 2021
@gwynne gwynne added this to Awaiting Review in Vapor 4 via automation Feb 12, 2021
gwynne
gwynne approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someday that print() will actually stay gone after being removed!

@gwynne gwynne merged commit 7c52814 into vapor:master Feb 12, 2021
Vapor 4 automation moved this from Awaiting Review to Done Feb 12, 2021
@tanner0101
Copy link
Member

These changes are now available in 1.4.3

@fabianfett fabianfett deleted the ff-sasl-stop-printing branch February 26, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees

@gwynne gwynne

Labels
bug Something isn't working
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianfett @tanner0101 @gwynne