Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use additional parameters #473

Merged
merged 8 commits into from May 9, 2024

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented May 8, 2024

Postgres-nio currently ignores additional parameters passed as an option, and doesn't send them in the startup message.
This PR fixes that.

Comment on lines 40 to 43

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just my Xcode settings ... not sure what to do?

Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🤦‍♂️ Two pointers on how to test

Tests/IntegrationTests/PostgresNIOTests.swift Outdated Show resolved Hide resolved
@fabianfett fabianfett enabled auto-merge (squash) May 9, 2024 19:11
Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fabianfett fabianfett merged commit a48eebc into vapor:main May 9, 2024
10 of 12 checks passed
@fabianfett fabianfett added the semver-patch No public API change. label May 10, 2024
@MahdiBM MahdiBM deleted the mmbm-use-additional-params branch May 10, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants