Fix zeros stripped in conversion from numeric #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug causing zeros to be stripped from numeric values such as 10234, producing 1234.
tanner0101
reviewed
Nov 5, 2018
| @@ -48,10 +48,10 @@ extension String: PostgreSQLDataConvertible { | |||
|
|
|||
| /// depending on our offset, append the string to before or after the decimal point | |||
| if offset < metadata.weight.bigEndian + 1 { | |||
| integer += string | |||
| integer += offset == 0 ? string : String(repeating: "0", count: 4 - string.count) + string | |||
There was a problem hiding this comment.
Breaking this up into one or two lines with some comments would make it a lot more readable I think
|
I can look into writing the test tomorrow (it’s late here). To be honest I don’t think a test should delay the merge of a critical data corruption bug fix. I could open a separate pull request.
… On 5 Nov 2018, at 21:18, Tanner ***@***.***> wrote:
I would love to include this change in 1.1.1. Let me know if you have any questions about writing the test. I'd also be happy to help write one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACksh_-y7RCy5dYR30FVtpadQbEGgTdks5usJ0LgaJpZM4YL7M7>.
|
michal-tomlein
force-pushed
the
numeric-zeros-bug
branch
2 times, most recently
from
6bfd36d
to
fbb2238
Compare
michal-tomlein
force-pushed
the
numeric-zeros-bug
branch
from
fbb2238
to
1259ab4
Compare
tanner0101
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Thanks, @michal-tomlein. I really appreciate you taking the time to submit this patch and a thorough test case.
|
Hey @michal-tomlein, you just merged a pull request, have a coin! You now have 1 coins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug causing zeros to be stripped from numeric values such as 10234.543201, producing 1234.54321.