Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dependency to swift-metrics #117

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Added dependency to swift-metrics #117

merged 6 commits into from
Aug 28, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Oct 6, 2022 •
edited by penny-for-vapor bot
Loading

These changes are now available in 1.16.0

Added a dependency to swift-metrics to be able to record metrics on queues.

Metrics added:

  • Timer to see how long a job takes to complete
  • Counter to keep track of dispatched jobs
  • Two different counters to keep track of successes and failures

@ptoffy ptoffy linked an issue Oct 6, 2022 that may be closed by this pull request
Output to Swift Metrics #112
Closed
@ptoffy ptoffy requested a review from 0xTim October 6, 2022 15:53
@ptoffy ptoffy force-pushed the 112-output-to-swift-metrics branch from faecb64 to 04b7fd6 Compare August 28, 2024 09:43
@ptoffy ptoffy force-pushed the 112-output-to-swift-metrics branch from 04b7fd6 to a285407 Compare August 28, 2024 10:05
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.48%. Comparing base (d867b5b) to head (aa9123e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/XCTQueues/TestQueueDriver.swift 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   83.16%   84.48%   +1.32%     
==========================================
  Files          22       22              
  Lines         677      709      +32     
==========================================
+ Hits          563      599      +36     
+ Misses        114      110       -4
Files with missing lines Coverage Δ
Sources/Queues/AsyncQueue.swift 100.00% <100.00%> (ø)
Sources/Queues/Queue.swift 87.03% <100.00%> (+1.03%) ⬆️
Sources/Queues/QueueWorker.swift 96.66% <100.00%> (+1.21%) ⬆️
Sources/XCTQueues/TestQueueDriver.swift 90.00% <50.00%> (ø)

... and 1 file with indirect coverage changes

0xTim
0xTim reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points for discussion

Sources/Queues/AsyncQueue.swift Outdated Show resolved Hide resolved
Sources/Queues/Queue.swift Outdated Show resolved Hide resolved
Tests/QueuesTests/Utilities/CapturingMetricsSystem.swift Outdated Show resolved Hide resolved
@ptoffy ptoffy requested a review from 0xTim August 28, 2024 12:58
@0xTim 0xTim added the semver-minor Contains new APIs label Aug 28, 2024
@ptoffy ptoffy requested a review from 0xTim August 28, 2024 15:39
@0xTim 0xTim merged commit be4ac72 into main Aug 28, 2024
8 checks passed
@0xTim 0xTim deleted the 112-output-to-swift-metrics branch August 28, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

@jdmcd jdmcd Awaiting requested review from jdmcd jdmcd is a code owner

Assignees
No one assigned
Labels
semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output to Swift Metrics
2 participants
@ptoffy @0xTim