Making Queues Sendable
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logging, always cancel tasks even if they error, and never deadlock in job scheduling.
…ructured logging, do much better logging, check delays properly, clear data from unregistered jobs, count remaining attempts properly (and without resetting maxRetryCount every time), and always requeue for retries, and just generally be better.
gwynne
force-pushed
the
sending-and-sendability
branch
from
fbb2ef5
to
7ce75cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 77.81% 82.86% +5.04%
==========================================
Files 21 22 +1
Lines 798 671 -127
==========================================
- Hits 621 556 -65
+ Misses 177 115 -62
|
MahdiBM
approved these changes
Jun 2, 2024
0xTim
approved these changes
Jun 13, 2024
… Sendable-safe, use assert instead of precondition in JobData init, update queuedAt value for retries in QueueWorker, QueuesCommand doesn't need to be @unchcked, make QueuesDriver require `Sendable`
…t LOG_LEVEL env var in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.15.0
The Queues package is now
Sendable-correct. Also includes a number of fixes:QueuesCommandnow does signal handling the same wayServeCommanddoes.QueueWorkernow handles retries in a much more consistent fashion and always requeues.AsyncQueuenow exists for creating Concurrency-based drivers