Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration API change #43

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Configuration API change #43

merged 2 commits into from
Nov 9, 2019

Conversation

madsodgaard
Copy link
Contributor

I gave my shot at implementing #39 according to the API proposed there.

jdmcd
jdmcd approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@jdmcd jdmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome stuff, thank you!!

@jdmcd jdmcd merged commit 322a9df into vapor:master Nov 9, 2019
@jdmcd jdmcd mentioned this pull request Nov 9, 2019
Closed
@madsodgaard madsodgaard deleted the configuration branch November 9, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdmcd jdmcd jdmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madsodgaard @jdmcd