Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building with Swift 5.2 #91

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Fix building with Swift 5.2 #91

merged 3 commits into from
Oct 26, 2020

Conversation

siemensikkema
Copy link
Member

Enables Queues to be built with Swift 5.2 again by adding missing self where needed. Also adds a test scenario for Swift 5.2 to prevent this from breaking in the future.

@siemensikkema siemensikkema added the semver-patch Internal changes only label Oct 23, 2020
@siemensikkema
Copy link
Member Author

@jdmcd this is a redo of #89 because I jumped the gun there and merged the PR without going through the steps to enable automated releasing by tanner-bot

@siemensikkema siemensikkema merged commit 9418af4 into master Oct 26, 2020
@siemensikkema siemensikkema deleted the feature/test-more-images branch October 26, 2020 11:11
@tanner0101
Copy link
Member

These changes are now available in 1.5.1

@0xTim 0xTim mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrLotU MrLotU MrLotU approved these changes

@jdmcd jdmcd Awaiting requested review from jdmcd

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siemensikkema @tanner0101 @MrLotU