Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented & added tests for basic set operations #129

Merged
merged 6 commits into from Feb 6, 2019

Conversation

Mordil
Copy link
Member

@Mordil Mordil commented Nov 30, 2018

implements: SREM, SADD, SPOP, SRANDMEMBER, SCARD, SISMEMBER, and SMEMBERS

Copy link
Member

@vzsg vzsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks! I found two minor things.

Sources/Redis/Client/Commands/Redis+List.swift Outdated Show resolved Hide resolved
Tests/RedisTests/RedisTests.swift Outdated Show resolved Hide resolved
@Mordil
Copy link
Member Author

Mordil commented Feb 4, 2019

@tanner0101 Bump :)

@tanner0101 tanner0101 added the enhancement New feature or request label Feb 6, 2019
@tanner0101 tanner0101 merged commit 71b5883 into master Feb 6, 2019
@penny-coin
Copy link

Hey @Mordil, you just merged a pull request, have a coin!

You now have 35 coins.

@tanner0101 tanner0101 deleted the add-set-commands branch February 6, 2019 20:31
@tanner0101
Copy link
Member

Leaving this untagged until we resolved #130, #131, #133, and #135. Would be nice to have all of those closed, then we can do a minor bump.

@tanner0101 tanner0101 added this to the 3.1.0 milestone Feb 6, 2019
@tanner0101 tanner0101 added this to Done in Vapor 3 Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Vapor 3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants