Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanups #209

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Misc cleanups #209

merged 11 commits into from
Jul 10, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 27, 2023 •
edited
Loading

  • Cleanup CI a little
  • Update README
  • Move CONTRIBUTING.md to .github
  • Make tests more reliable

@gwynne gwynne added the semver-minor Contains new APIs label May 27, 2023
@gwynne gwynne requested a review from 0xTim May 27, 2023 16:51
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023 •
edited
Loading

Codecov Report

Merging #209 (e876f50) into main (2a8d3e4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   55.58%   55.58%           
=======================================
  Files          11       11           
  Lines         412      412           
=======================================
  Hits          229      229           
  Misses        183      183

MahdiBM
MahdiBM reviewed May 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
MahdiBM
MahdiBM approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the CI is failing because there are some new Thread Sanitizer stuff on Swift 5.8+.
I'd rather a happy Thread Sanitizer than not, but that is unrelated to what changes this PR has made.

@gwynne
Copy link
Member Author

gwynne commented May 28, 2023

The TSan failures are solved in https://gitlab.com/swift-server-community/RediStack/-/merge_requests/196 and https://gitlab.com/swift-server-community/RediStack/-/merge_requests/197.

@gwynne gwynne added semver-patch Internal changes only and removed semver-minor Contains new APIs labels Jul 10, 2023
@MahdiBM MahdiBM merged commit 9e42dea into main Jul 10, 2023
11 checks passed
@MahdiBM MahdiBM deleted the gwynne-patch-1 branch July 10, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mordil Mordil Mordil approved these changes

@0xTim 0xTim 0xTim approved these changes

@MahdiBM MahdiBM MahdiBM approved these changes

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gwynne @codecov-commenter @Mordil @0xTim @MahdiBM