Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onUnexpectedConnectionClose #210

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Add onUnexpectedConnectionClose #210

merged 2 commits into from
Jun 14, 2023

Conversation

marius-se
Copy link
Contributor

Adds new onUnexpectedConnectionClose callback which got added in RediStack 1.4.0

@marius-se marius-se requested a review from 0xTim June 12, 2023 08:53
@0xTim 0xTim added the semver-minor Contains new APIs label Jun 12, 2023
@0xTim
Copy link
Member

0xTim commented Jun 14, 2023

API breakage is fine, isn't picking up the default parameter

@0xTim
Copy link
Member

0xTim commented Jun 14, 2023

@Mordil anything to add?

@marius-se
Copy link
Contributor Author

Let's update to the latest package version before merging

@0xTim 0xTim merged commit b4fcda8 into main Jun 14, 2023
4 of 5 checks passed
@0xTim 0xTim deleted the feature/connection_close branch June 14, 2023 08:31
@VaporBot
Copy link

These changes are now available in 5.0.0-alpha.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mordil Mordil Mordil approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marius-se @0xTim @VaporBot @Mordil