redis 2.0

[tanner0101]

• 5x faster
• 3.5k lines of code removed

2.0

1.0

Todo:

• Transport Streams from Engine

[jdmcd]

Would it be possible to implement an expiration time on Redis using EXPIRE?

[tanner0101]

@mcdappdev besides supporting expire in the Command enum, idk how much use that would be here. But adding that to the CacheProtocol in vapor would be awesome!

[jdmcd]

Cool! I could take a crack at that, if you'd like! On Thu, Mar 16, 2017 at 5:53 PM, Tanner <notifications@github.com> wrote: @mcdappdev [https://github.com/mcdappdev] besides supporting the command in the Command enum, idk how much use that would be here. But adding that to the CacheProtocol in vapor would be awesome! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [#56 (comment)] , or mute the thread [https://github.com/notifications/unsubscribe-auth/ALS0IWOEVOE9ziXPMDq837aqHeLkpoQEks5rmb1NgaJpZM4MfueW] .

[tanner0101]

@mcdappdev sure thing :) I should have this merged and tagged once I pull in the proper Stream protocols (will be done in 12-24 hours)

here's the cache protocol to start with
https://github.com/vapor/vapor/blob/9b0701479b39996b56ada92565cded106c73b57b/Sources/Cache/CacheProtocol.swift

[jdmcd]

Cool! Thanks On Thu, Mar 16, 2017 at 6:00 PM, Tanner <notifications@github.com> wrote: @mcdappdev [https://github.com/mcdappdev] sure thing :) I should have this merged and tagged once I pull in the proper Stream protocols (will be done in 12-24 hours) here's the cache protocol to start with https://github.com/vapor/vapor/blob/9b0701479b39996b56ada92565cded106c73b57b/Sources/Cache/CacheProtocol.swift [https://github.com/vapor/vapor/blob/9b0701479b39996b56ada92565cded106c73b57b/Sources/Cache/CacheProtocol.swift] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [#56 (comment)] , or mute the thread [https://github.com/notifications/unsubscribe-auth/ALS0IQE5jHKgkHsSI0dzPNdhgpgsSgNxks5rmb8KgaJpZM4MfueW] .

[vzsg]

@mcdappdev I wrote a proposal with CacheProtocol changes after your idea, back when we were discussing this on Slack 😛 Apparently it flew below the radar: vapor/vapor#907

[jdmcd]

@vzsg I love it! I just left one comment but other than that I'm a big fan.