Conform to database kit, added auth #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner0101
reviewed
Mar 27, 2018
| /// Create a new `RedisClientConfig` | ||
| public init(hostname: String, port: Int) { | ||
| self.hostname = hostname | ||
| self.port = port | ||
| } | ||
|
|
||
| public init(hostname: String, port: Int, password: String) { |
There was a problem hiding this comment.
Could do a default arg on the main init instead
tanner0101
previously approved these changes
Mar 27, 2018
tanner0101
approved these changes
Mar 28, 2018
Closed
|
Got a failure the first run, now it's working. Hmm.. >_>. If you run this branch locally multiple times does it always succeed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tanner0101