Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Logger instead of print() #126

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Use a Logger instead of print() #126

merged 6 commits into from
Aug 16, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 15, 2023

Fixes #125

Also does some miscellaneous long-overdue cleanup.

@gwynne gwynne added bug Something isn't working semver-minor Contains new API labels Aug 15, 2023
@gwynne gwynne requested review from 0xTim and MahdiBM August 15, 2023 03:00
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #126 (3cabeb0) into main (611bc45) will increase coverage by 0.34%.
Report is 2 commits behind head on main.
The diff coverage is 25.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   83.27%   83.62%   +0.34%     
==========================================
  Files           4        4              
  Lines         287      232      -55     
==========================================
- Hits          239      194      -45     
+ Misses         48       38      -10     
Files Changed Coverage Δ
Sources/RoutingKit/AnyRouter.swift 0.00% <ø> (ø)
Sources/RoutingKit/TrieRouter.swift 93.29% <16.66%> (-2.59%) ⬇️
Sources/RoutingKit/Parameters.swift 75.00% <50.00%> (ø)

... and 1 file with indirect coverage changes

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of queries

Sources/RoutingKit/TrieRouter.swift Outdated Show resolved Hide resolved
Sources/RoutingKit/TrieRouter.swift Show resolved Hide resolved
Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes 🙂

@gwynne gwynne requested a review from 0xTim August 16, 2023 10:44
@gwynne gwynne enabled auto-merge (squash) August 16, 2023 10:44
@gwynne gwynne merged commit e0539da into main Aug 16, 2023
13 checks passed
@gwynne gwynne deleted the fix-use-of-print branch August 16, 2023 10:54
@penny-for-vapor
Copy link

These changes are now available in 4.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-minor Contains new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid print in TrieRouter.swift
4 participants