Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiply-defined route error message #127

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Oct 13, 2023

The log message that appears when a route with the same path and method has been specified more than once is now more understandable.

Also the usual bits of cleanup.

@gwynne gwynne added enhancement New feature or request semver-patch Internal changes only labels Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #127 (8b9749e) into main (e0539da) will increase coverage by 0.13%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   83.62%   83.76%   +0.13%     
==========================================
  Files           4        4              
  Lines         232      234       +2     
==========================================
+ Hits          194      196       +2     
  Misses         38       38              
Files Coverage Δ
Sources/RoutingKit/TrieRouter.swift 93.37% <66.66%> (+0.08%) ⬆️

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne merged commit 88077f2 into main Oct 13, 2023
12 checks passed
@gwynne gwynne deleted the better-log-message branch October 13, 2023 17:06
@penny-for-vapor
Copy link

These changes are now available in 4.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants