Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform PathComponent to Hashable and Equatable #129

Merged
merged 3 commits into from Dec 22, 2023
Merged

Conform PathComponent to Hashable and Equatable #129

merged 3 commits into from Dec 22, 2023

Conversation

marius-se
Copy link
Contributor

@marius-se marius-se commented Dec 17, 2023 •
edited by penny-for-vapor bot

These changes are now available in 4.9.0

Conforms PathComponent to Equatable. Related to this PR

@gwynne
Copy link
Member

gwynne commented Dec 17, 2023

Might as well conform it to Hashable (which itself requires Equatable, so no need to conform to both)

@marius-se
Copy link
Contributor Author

@gwynne done ✅

@gwynne
Copy link
Member

gwynne commented Dec 17, 2023

One more nit: Why do it on an extension when several other conformances are already on the initial declaration?

@gwynne gwynne added enhancement New feature or request semver-minor Contains new API labels Dec 17, 2023
0xTim
0xTim requested changes Dec 18, 2023
View reviewed changes
Sources/RoutingKit/PathComponent.swift Outdated Show resolved Hide resolved
@gwynne gwynne changed the title Conform PathComponent to Equatable Conform PathComponent to Hashable and Equatable Dec 22, 2023
@gwynne gwynne merged commit 2a92a7e into main Dec 22, 2023
13 checks passed
@gwynne gwynne deleted the equatable_path_component branch December 22, 2023 09:47
@marius-se marius-se mentioned this pull request Jan 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-minor Contains new API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marius-se @gwynne @0xTim