-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CREATE TABLE ... SELECT ...
#141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…having()`, and `orHaving()` for `SQLSelectBuilder`, making them fully consistent with themselves and each other (with the exception of not providing the missing untyped `Encodable` overload for `where()` since it wasn't desirable to have it at all to begin with). Separates the `HAVING` predicate into its own secondary predicate builder.
…tocol. Despite all appearances to the contrary, the public API does not change (aside from gaining a couple of extra methods for consistency in the `where` and `having` method suites).
I don't think I can give a good review on this repo, I'll pass. |
0xTim
approved these changes
Dec 1, 2021
These changes are now available in 3.14.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SQLKit support for creating tables populated by
SELECT
queries:Additional changes:
SQLSelectBuilder
..where()
,.orWhere()
,.having()
, and.orHaving()
families of methods onSQLSelectBuilder
(and otherSQLPredicateBuilders
) have been normalized so that all four sets of methods offer the same series of overloads as all the others.async
tests.DROP TEMPORARY TABLE
syntax, assqlDatabase.drop(table: "table").temporary()
.Note: Despite what may seem appearances to the contrary, the public API of
SQLSelectBuilder
has not lost any methods, though it has gained a small number of overloads. A concerted effort was made to avoid changing any existing API in any source-incompatible way.