Allow URLEncodedForms to decode 'on' value als Bool => true

vapor · Oct 11, 2021 · 5137fc8 · 5137fc8
1 parent 2711927
commit 5137fc8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/Sources/Vapor/URLEncodedForm/URLQueryFragmentConvertible.swift b/Sources/Vapor/URLEncodedForm/URLQueryFragmentConvertible.swift
@@ -78,6 +78,7 @@ extension Bool: URLQueryFragmentConvertible {
         switch decodedString.lowercased() {
         case "1", "true": self = true
         case "0", "false": self = false
+        case "on": self = true
         default: return nil
         }
     }

diff --git a/Tests/VaporTests/URLEncodedFormTests.swift b/Tests/VaporTests/URLEncodedFormTests.swift
@@ -432,6 +432,14 @@ final class URLEncodedFormTests: XCTestCase {
         let foo = try URLEncodedFormDecoder().decode(Foo.self, from: "flag")
         XCTAssertEqual(foo.flag, true)
     }
+
+    func testFlagIsOnDecodingAsBool() throws {
+        struct Foo: Codable {
+            var flag: Bool
+        }
+        let foo = try URLEncodedFormDecoder().decode(Foo.self, from: "flag=on")
+        XCTAssertEqual(foo.flag, true)
+    }
 
     /// https://github.com/vapor/url-encoded-form/issues/3
     func testGH3() throws {