Allow URLEncodedForms to decode 'on' value als Bool => true

[bobvoorneveld]

When a HTML form uses a checkbox to check something as a Bool, it sends the 'on' value if checked.
The URLEncodedForms decoder should be able to handle that.

<form method="post">
 <input type="checkbox" name="isActive" checked />
 </form>

struct FormData: Decodable {
    let isActive: Bool
}

let formData = try req.content.decode(FormData.self)

fixes #2444

[0xTim]

@bobvoorneveld Thanks for this! Just a note to say it hasn't been forgotten, I just to spend some time to sit down and read the form spec etc to make sure we're all good. But wanted you to know this wasn't getting lost in a void!

[bobvoorneveld]

NP, keep up the good work!

I'm just merging main because I'm using my own branch as the base of one of my projects.

[bobvoorneveld]

Reading some documentation on input checkboxes via https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox

If the value attribute was omitted, the default value for the checkbox is on, so the submitted data in that case would be subscribe=on.

I can solve this by adding a value to 1 in the input type. But would be nice to support this behaviour?

Is this the spec that you need to confirm?

https://html.spec.whatwg.org/multipage/input.html#dom-input-value-default-on

[Joannis]

LGTM, spec looks correct

[Joannis]

@0xTim or @gwynne any objection to merging this?

[Joannis]

I also don't know if this is a semver-minor or semver-patch

[VaporBot]

These changes are now available in 4.69.1