Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Storage thread safe #2868

Closed
grahamburgsma opened this issue Aug 11, 2022 · 1 comment
Closed

Make Storage thread safe #2868

grahamburgsma opened this issue Aug 11, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@grahamburgsma
Copy link
Contributor

As discussed on Discord https://discord.com/channels/431917998102675485/519613337638797315/1007276508894728322.

Multiple concurrent accesses to Storage can result in a segmentation fault. In my case, multiple async let Fluent queries caused this crash:

Screen Shot 2022-08-11 at 10 16 46 AM

Environment

  • Vapor Framework version: 4.65.0
@grahamburgsma grahamburgsma added the bug Something isn't working label Aug 11, 2022
@0xTim 0xTim linked a pull request Aug 18, 2022 that will close this issue
Async Next Steps #2873
Closed
@0xTim
Copy link
Member

0xTim commented Nov 1, 2023

This is now resolved

@0xTim 0xTim closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Async Next Steps vapor/vapor
2 participants
@grahamburgsma @0xTim