-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response compression handler not added for HTTP2 requests #3125
Labels
bug
Something isn't working
Comments
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 3, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 3, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 7, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 7, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 23, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 24, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Jan 30, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Feb 11, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Feb 14, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Feb 21, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Mar 23, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Apr 15, 2024
…quest recompression Fixes vapor#3125
dimitribouniol
added a commit
to dimitribouniol/vapor
that referenced
this issue
Apr 19, 2024
…quest recompression Fixes vapor#3125
0xTim
pushed a commit
that referenced
this issue
Apr 19, 2024
* Fixed an issue where HTTP2 didn't support response compression and request recompression Fixes #3125 * Added exhaustive tests for request and response compression across both HTTP 1.1 and HTTP 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I noticed the response compression didn't work for HTTP2 requests, because the
addVaporHTTP2Handlers()
method doesn't seem to add the handlers like the HTTP1 handler does.To Reproduce
supportedVersions
line (and thus HTTP2) enables compression as expected.HTTP1.1:
![image](https://private-user-images.githubusercontent.com/225505/293913827-e5b454f9-806c-4916-a54c-6fbeb6ba7f9a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTczNzksIm5iZiI6MTcyMTc1NzA3OSwicGF0aCI6Ii8yMjU1MDUvMjkzOTEzODI3LWU1YjQ1NGY5LTgwNmMtNDkxNi1hNTRjLTZmYmViNmJhN2Y5YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyM1QxNzUxMTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMThiZThjYjc2NWRjZjQ1ZDhjZTdlYzMyOWFkOTA1MjZmYzU0NzBjYzAzZjFlNjVkYmNhYjkyNmU5Yjg5ZmY2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.KUoUwGjNKuDBisNM9wwvewZ0Fs4rgUKJFzXVmIiPdyc)
HTTP2:
![image](https://private-user-images.githubusercontent.com/225505/293913752-19a01397-7810-47c7-a3cd-1cb27075a03d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTczNzksIm5iZiI6MTcyMTc1NzA3OSwicGF0aCI6Ii8yMjU1MDUvMjkzOTEzNzUyLTE5YTAxMzk3LTc4MTAtNDdjNy1hM2NkLTFjYjI3MDc1YTAzZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyM1QxNzUxMTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zYjkxNTYwMTU0YTM4NDUwNmZjZDliYWZjNWJmMGJhOTQxOWEwZjE4MmM0MjczNDEwYTdhNGRhY2ZkNTdhNGE2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.J_4el0j3sB9qW2aHqyYsY3S3mhOVG9oxZ4cKm9sDU_g)
Expected behavior
Responses should be compressed when accessed over typical browsers.
Environment
The text was updated successfully, but these errors were encountered: