Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double encoded post requests after recent update (4.89.3 → 4.91.1) #3133

Closed
finestructure opened this issue Jan 8, 2024 · 1 comment · Fixed by #3140
Closed

Double encoded post requests after recent update (4.89.3 → 4.91.1) #3133

finestructure opened this issue Jan 8, 2024 · 1 comment · Fixed by #3140
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@finestructure
Copy link
Sponsor Member

Our social media posts made via

        struct Query: Encodable {
            var status: String
        }

        let res = try await client.post(URI(string: apiURL), headers: headers) { req in
            try req.query.encode(Query(status: message))
        }

started showing up as

Screenshot 2024-01-08 at 13 11 18@2x

after updating from Vapor 4.89.3 → 4.91.1 today.

@gwynne seems to know what the issue might be, adding the issue for tracking purposes.

@finestructure finestructure added the bug Something isn't working label Jan 8, 2024
@gwynne gwynne self-assigned this Jan 8, 2024
@gwynne gwynne added the duplicate This issue or pull request already exists label Jan 19, 2024
@gwynne
Copy link
Member

gwynne commented Jan 19, 2024

Duping to #3138, the central tracking for the underlying issue.

@gwynne gwynne closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants