Fix broken URI behaviors #3140
Merged
Fix broken URI behaviors #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3140 +/- ##
==========================================
+ Coverage 76.75% 76.79% +0.03%
==========================================
Files 211 211
Lines 8020 8084 +64
==========================================
+ Hits 6156 6208 +52
- Misses 1864 1876 +12
|
gwynne
force-pushed
the
fix-broken-uri
branch
2 times, most recently
from
ac91cbb
to
63b7f60
Compare
gwynne
force-pushed
the
fix-broken-uri
branch
from
63b7f60
to
6228ad3
Compare
gwynne
force-pushed
the
fix-broken-uri
branch
from
56d63b9
to
a99f79e
Compare
0xTim
approved these changes
Jan 22, 2024
0xTim
approved these changes
Jan 22, 2024
|
We do - there were three actual issues filed plus the one I opened as a central point of reference. All three original tickets have new individual tests marked with the issue numbers, plus the many additional tests of URI that were added in the original URI PR (and updated to be correct in this one). |
keniwhat
pushed a commit
to keniwhat/vapor
that referenced
this pull request
Apr 27, 2024
* main: Patch configuration and log actual port on startup (vapor#3160) Update provider tests to 5.10 (vapor#3178) Migrate to Async NIOFileIO APIs (vapor#3167) Removed streamFile deprecation + deactivated advancedETagComparison by default (vapor#3177) Remove HeadResponder (vapor#3147) Advanced ETag Comparison now supported (vapor#3015) Enabled Request Decompression By Default (vapor#3175) HTTP2 Response Compression/Request Decompression (vapor#3126) Don't set ignore status for SIGTERM and SIGINT on Linux (vapor#3174) Fix typos across the codebase (vapor#3162) Fix some Sendable warnings on 5.10 (vapor#3158) Allow `HTTPServer`'s configuration to be dynamically updatable (vapor#3132) Fix issue when client disconnects midway through a stream (vapor#3102) Fix handling of "flag" URL query params (vapor#3151) Bump the dependencies group with 1 update (vapor#3148) Merge Async Tests (vapor#3141) Fix URI handling with multiple slashes and variable components. (vapor#3143) Fix broken URI behaviors (vapor#3140) # Conflicts: # Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.92.0
Numerous issues have arisen with the changes made to
URIas a result of the fix for GHSA-r6r4-5pr8-gjcp. This update fixes all known issues and restores several changedURIbehaviors (although, quite deliberately, not all of them), including new tests. Fixes #3133, #3135, #3137, and #3138.Also addresses
Sendablewarnings inContentEncoder,ContentDecoder,ContentContainer,PlaintextDecoder,PlaintextEncoder,URLQueryDecoder,URLQueryEncoder,URLQueryContainer,URLEncodedFormDecoder, andURLEncodedFormEncoder.Shoutout to @weissi, @grahamburgsma, and @finestructure for their help tracking down the various problems, thank you all!