HTTP2 and gzip #1188
Merged
HTTP2 and gzip #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: OpenSSL
tanner0101
approved these changes
Nov 29, 2017
Sources/Async/Streams/Stream.swift
Outdated
| @@ -0,0 +1,80 @@ | |||
| /// A stream is both an InputStream and an OutputStream | |||
| public typealias Stream = InputStream & OutputStream | |||
There was a problem hiding this comment.
async module should be removed.
| import Async | ||
| import Bits | ||
|
|
||
| public final class BodyStream: Async.Stream, ClosableStream { |
| import Bits | ||
| import Foundation | ||
|
|
||
| final class ChunkEncoder: Async.Stream, ClosableStream { |
| stream.onClose(onClose) | ||
| } | ||
|
|
||
| /// - TODO: Improve performance |
There was a problem hiding this comment.
we should make that a private comment
|
|
||
| // Send the settings, next | ||
| client.updateSettings(to: settings) | ||
| }.catch(client.promise.fail) |
| extension HTTP2Client { | ||
| /// Updates the frame's contents as settings, sends an acknowledgement | ||
| /// | ||
| /// TODO: Settings changed in the middle of the stream affecting the context |
There was a problem hiding this comment.
we should have these as // so they don't show up in the documentation
There was a problem hiding this comment.
They won't, since they're internal APIs. And they serve as a good reminder
| ] | ||
|
|
||
| func testClient() throws { | ||
| // #if os(Linux) |
There was a problem hiding this comment.
can we get these working before merging?
There was a problem hiding this comment.
I don't have an HTTP/2 host that I can test again. External hosts like google.com can not be connected to from CircleCI
| XCTAssertThrowsError(try parser.parse(from: data)) | ||
| } | ||
|
|
||
| func testTooLargeResponse() throws { |
Plug some small Vapor 3 memory leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will focus on HTTP2 and Gzip.
The reason this is bundled is because HTTP2 relies on Huffman trees, which are are one of the primary components of Gzip. Gzip will not implement a good algorithm such as LZ77 yet but will instead use a primitive and unperformant implementation as a placeholder for a future PR.
Current state:
More todos will be added once they're almost up for development...