Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Logger+LogError #1660

Merged
merged 1 commit into from May 8, 2018
Merged

Fix typo in Logger+LogError #1660

merged 1 commit into from May 8, 2018

Conversation

MihaelIsaev
Copy link
Member

@MihaelIsaev MihaelIsaev commented May 6, 2018 •
edited

Looks like there should be e instead of error because error is function

Checklist

  • Circle CI is passing (code compiles and passes tests).
  • There are no breaking changes to public API.
  • New test cases have been added where appropriate.
  • All new code has been commented with doc blocks ///.

@MihaelIsaev
Fix typo
6f1ba24 
Looks like there should be `e` instead of `error`
@MihaelIsaev MihaelIsaev changed the title Fix typo Fix typo in Logger+LogError May 6, 2018
tanner0101
tanner0101 approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks!

@tanner0101 tanner0101 added the bug Something isn't working label May 8, 2018
@tanner0101 tanner0101 self-assigned this May 8, 2018
@tanner0101 tanner0101 added this to the 3.0.2 milestone May 8, 2018
@tanner0101 tanner0101 merged commit 382de71 into vapor:master May 8, 2018
@penny-coin
Copy link

Hey @MihaelIsaev, you just merged a pull request, have a coin!

You now have 1 coins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees

@tanner0101 tanner0101

Labels
bug Something isn't working
Projects
No open projects
Vapor 3
  
Awaiting triage
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MihaelIsaev @penny-coin @tanner0101