New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a non-variadic 'on' method to router #1666

Merged
merged 1 commit into from May 8, 2018

Conversation

2 participants
@tanner0101
Copy link
Member

tanner0101 commented May 8, 2018

Adds a non-variadic overload to router.on(...) to allow users to easier extend Vapor's router. Fixes #1658

@tanner0101 tanner0101 added the bug label May 8, 2018

@tanner0101 tanner0101 added this to the 3.0.2 milestone May 8, 2018

@tanner0101 tanner0101 self-assigned this May 8, 2018

@tanner0101 tanner0101 merged commit 8119c06 into master May 8, 2018

3 checks passed

ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-api-template Your tests passed on CircleCI!
Details
ci/circleci: linux-release Your tests passed on CircleCI!
Details
@penny-coin

This comment has been minimized.

Copy link

penny-coin commented May 8, 2018

Hey @tanner0101, you just merged a pull request, have a coin!

You now have 37 coins.

@tanner0101 tanner0101 deleted the non-variadic-on branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment