Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a non-variadic 'on' method to router #1666

Merged
merged 1 commit into from May 8, 2018
Merged

add a non-variadic 'on' method to router #1666

merged 1 commit into from May 8, 2018

Conversation

tanner0101
Copy link
Member

Adds a non-variadic overload to router.on(...) to allow users to easier extend Vapor's router. Fixes #1658

@tanner0101 tanner0101 added the bug Something isn't working label May 8, 2018
@tanner0101 tanner0101 added this to the 3.0.2 milestone May 8, 2018
@tanner0101 tanner0101 self-assigned this May 8, 2018
@tanner0101 tanner0101 merged commit 8119c06 into master May 8, 2018
@penny-coin
Copy link

Hey @tanner0101, you just merged a pull request, have a coin!

You now have 37 coins.

@tanner0101 tanner0101 deleted the non-variadic-on branch May 8, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tanner0101 tanner0101

Labels
bug Something isn't working
Projects
No open projects
Vapor 3
  
Awaiting triage
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanner0101 @penny-coin