Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix maxBodySize typo #1691

Merged
merged 2 commits into from Jun 5, 2018
Merged

fix maxBodySize typo #1691

merged 2 commits into from Jun 5, 2018

Conversation

grundoon
Copy link
Member

@grundoon grundoon commented May 21, 2018 •
edited by rafiki270

NIOServerConfig has maxBodySize set to 1_000_0000 – presumed to be a typo and corrected to match the 1_000_000 (1MB) value that exists throughout vapor/http

Checklist

  • Circle CI is passing (code compiles and passes tests).
  • There are no breaking changes to public API.
  • New test cases have been added where appropriate.
  • All new code has been commented with doc blocks ///.

rafiki270
rafiki270 approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@rafiki270 rafiki270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that has to be a typo :)

tanner0101
tanner0101 approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tanner0101 tanner0101 added this to the 3.0.4 milestone Jun 5, 2018
@tanner0101 tanner0101 added the bug Something isn't working label Jun 5, 2018
@tanner0101 tanner0101 self-assigned this Jun 5, 2018
@penny-coin
Copy link

Hey @grundoon, you just merged a pull request, have a coin!

You now have 52 coins.

@tanner0101 tanner0101 merged commit 34793d0 into vapor:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiki270 rafiki270 rafiki270 approved these changes

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees

@tanner0101 tanner0101

Labels
bug Something isn't working
Projects
No open projects
Vapor 3
  
Awaiting triage
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grundoon @penny-coin @rafiki270 @tanner0101