wrk improvements #174
wrk improvements #174
Conversation
| return | ||
| } | ||
| var keepAlive = false | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| where next != newLine | ||
| && !closed { | ||
| var next: Byte? | ||
| while next != newLine && !closed { |
There was a problem hiding this comment.
I'm not sure I understand the difference here., am I missing something?
There was a problem hiding this comment.
Before, if the first byte(s) received were nil, it would assume end of line and return whatever it had. It looks like some requests (especially wrk) start with an empty byte. So the empty byte came in, this skipped and returned an empty string, the request line got parsed as invalid, then it was all wonky after that.
Now it will only assumes the line is done when it gets a new line character, which seems to be more technically valid, and also totally fixed the InvalidComponents issue.
|
|
# Conflicts: # Vapor.xcodeproj/project.pbxproj # Vapor.xcodeproj/project.xcworkspace/xcshareddata/Vapor.xcscmblueprint # Vapor.xcodeproj/xcshareddata/xcschemes/Vapor.xcscheme
No description provided.