[Don't merge] Use private container to get database connection #1766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple requests can grab same database connection.
See DatabaseKit issue #43 for details.
Request
tries to get database connection from self (asContainer
). Internally the connection is cached in the container.But
Request
isAliasedContainer
, so cache is shared among the requests.If the server receives two (or more) requests simultaneously, they use the same database connection and it can crash here for MySQL, or somewhere else for other DB.
To make cache not shared, I changed to use
privateContainer
instead ofRequest
itself.There is similar situation so I think it may work well.
Checklist
///
.