Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Storage to Request + Response, deprecate userInfo #2216

Merged
merged 1 commit into from
Mar 6, 2020
Merged

add Storage to Request + Response, deprecate userInfo #2216

merged 1 commit into from
Mar 6, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Mar 6, 2020 •
edited
Loading

Adds Request.storage and Response.storage for storing user-defined values. userInfo has been deprecated since Storage is more type-safe and performant (#2216).

@tanner0101 tanner0101 added enhancement New feature or request semver-minor Contains new API labels Mar 6, 2020
@tanner0101 tanner0101 added this to In Progress in Vapor 4 via automation Mar 6, 2020
tonyarnold
tonyarnold approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@tonyarnold tonyarnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid improvement to me 👍 :shipit:

@tanner0101 tanner0101 merged commit 13ecf37 into master Mar 6, 2020
Vapor 4 automation moved this from Awaiting Review to Done Mar 6, 2020
@tanner0101 tanner0101 deleted the tn-storage branch March 6, 2020 03:35
@tanner0101
Copy link
Member Author

These changes are now available in 4.0.0-rc.2.1

pull bot pushed a commit to scope-demo/vapor that referenced this pull request Mar 6, 2020
@tanner0101 @pull
add Storage to Request + Response, deprecate userInfo (vapor#2216)
41c9551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyarnold tonyarnold tonyarnold approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-minor Contains new API
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanner0101 @tonyarnold