-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FileIO.writeFile #2418
Merged
Merged
Add FileIO.writeFile #2418
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
953d5e0
Add FileIO.write
t-ae 826bc11
Refactor
t-ae 36687a9
Merge branch 'master' into fileio-write
tanner0101 971646a
Change signature
t-ae 9ae29be
Merge branch 'master' into fileio-write
tanner0101 bfb829b
Refine test
t-ae dadf4d5
Add code example
t-ae File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this is a useful addition! I just wonder what should happen to existing files. Would they append to or overwrite the existing file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method overwrites target file.
For appending, we have to pass
O_APPEND
flag toNIOFileHandle
.How about to add
FileIO.write(fileHandle: NIOFileHandle, buffer: ByteBuffer)
?User can create
NIOFileHandle
withO_APPEND
flag and pass it.The merit of this method is that user can control when to close
fileHandle
.It would be useful especially when appending to single file many times.