Fixing issue #2755: using a reference type config #2881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we change HTTPServer.Configuration to be a reference type rather than a value type we can then pass this reference into HTTPServer from the server extension service and then any changes done inside HTTPServer are automatically reflected on the storage in the server extension service
|
This is an alternative to #2882 |
|
Closing in favor of the alternative PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we change HTTPServer.Configuration to be a reference type rather than a value type we can then pass this reference into HTTPServer from the server extension service and then any changes done inside HTTPServer are automatically reflected on the storage in the server extension service.
There are no changes in terms of usage, though now if you pass
--hostname hostwhen serving your appapp.http.server.configwill reflect that change (whereas before it was keeping the default value of127.0.0.1)Resolves #2755