Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded ports in tests #3071

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Remove hardcoded ports in tests #3071

merged 6 commits into from
Sep 22, 2023

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Sep 21, 2023

Resolves #3052 and #2568

Tests can now be run in parallel and pass

@0xTim 0xTim requested a review from gwynne as a code owner September 21, 2023 13:04
@0xTim 0xTim linked an issue Sep 21, 2023 that may be closed by this pull request
@0xTim 0xTim added the no-release-needed Doesn't require a release label Sep 21, 2023
@gwynne gwynne merged commit 8f230c6 into main Sep 22, 2023
16 checks passed
@gwynne gwynne deleted the hardcoded-ports-in-tests branch September 22, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release-needed Doesn't require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 27 occurrences of hardcoded port in vapor tests running Vapor tests in parallel fails
2 participants