Fix NIOLoopBound issues #3081
Merged
Fix NIOLoopBound issues #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
reviewed
Oct 5, 2023
Tests/VaporTests/PipelineTests.swift
Outdated
| var eventLoopGroup: EventLoopGroup! | ||
|
|
||
| override func setUp() async throws { | ||
| eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: 8) |
There was a problem hiding this comment.
I'll switch the this, this was my attempts to make it crash and ensure we definitely had more than one event loop
|
I've audited the other usages of |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
==========================================
+ Coverage 76.31% 76.34% +0.02%
==========================================
Files 211 211
Lines 7853 7862 +9
==========================================
+ Hits 5993 6002 +9
Misses 1860 1860
|
gwynne
approved these changes
Oct 6, 2023
|
These changes are now available in 4.84.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of issues where
NIOLoopBoundandNIOLoopBoundBoxwere used without ensuring we were on the correct event loop before accessing them. This could lead to precondition crashes