New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snake-key decoding strategy for URLQuery #3094
Open
MahdiBM
wants to merge
10
commits into
vapor:main
Choose a base branch
from
MahdiBM:mmbm-url-query-snake-case
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+259
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought my misclick is merging the PR to main without a review 😵💫 |
It can't until it's had an approval |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3094 +/- ##
==========================================
+ Coverage 76.23% 76.32% +0.08%
==========================================
Files 211 211
Lines 7904 7963 +59
==========================================
+ Hits 6026 6078 +52
- Misses 1878 1885 +7
|
MahdiBM
force-pushed
the
mmbm-url-query-snake-case
branch
from
November 3, 2023 06:17
d0820a8
to
7e01c2c
Compare
hmm that didn't turn out like i was thinking it would 🤔 just caused a bunch of whitespace changes for the most part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds snake-key decoding strategy for URLQuery.
Matches Foundation's JSONDecoder implementation although i found like 3 different key-handling bugs in that implementation while writing this.