Decode percent encoded strings in parameters

[kylebshr]

This is a simple PR that decodes strings using stringByRemovingPercentEncoding before inserting them into parameters. Almost every web server does this automatically.

I was unsure of what to do with regards to tests, as I didn't see existing tests for the parameters. If I could get feedback on that, I would love to write tests if needed.

[tanner0101]

Are you working with Vapor in Xcode? If so, you should be able to create a new file in the Tests folder, following the structure of the two tests that already exist in there. (I just added another one a few minutes ago, so you may need to merge master into your fork to see it).

Then select the Tests Scheme (There should only be Vapor and Tests), and hit command + u to run the tests.

Otherwise, this PR looks good. We will see if Travis comes back with the OK.

[kylebshr]

Sorry if I wasn't clear — I can run the existing tests, and I know how to add new ones. I just didn't see any existing tests that tests the parameters, so I wasn't really sure how to start some from scratch (since I'm not too familiar with how the project is structured).

If I have time to look into it more though, I'll look into writing same basic tests. I looked at the RouterTests again and I think I could do something similar.

[tanner0101]

Ah okay. There have been basically no tests written yet, so lots to do... The ResponseTests was there just to make sure the Tests scheme worked really. RouterTests is the first unit test written alongside a new feature.

I would include the test for this PR in the RouterTests file as a separate function–called testUrlParameters() or something like that...

If you want to add additional tests for other aspects of Vapor (which would be greatly appreciated), you could submit that as a separate PR.

[tanner0101]

Fixes issue #32.

[kylebshr]

Working on tests right now, how would I go about updating this PR? My GitHub fu is lacking.

[tanner0101]

Any commits you make to the branch involved in this PR (kylebshr:master) will automatically appear here.

[kylebshr]

Alrighty! Added a test if you wanna take a look, assuming travis is happy of course.

[tanner0101]

To improve the test, you could consider writing the decoded string manually. This way if stringByRemovingPercentEncoding fails (which it could since I think it's included in the Swift linux fixes) we will know.

[kylebshr]

Will do! Wasn't sure about that, I'm still new to writing unit tests 👍

[kylebshr]

I realized that the test can still pass if the handler doesn't run (if someone modified the test and the handler never got called for some reason). I added in an assertion to make sure the handler was run — is there a better way to do that, or is it a good check?

[tanner0101]

Everything looks great. Thank you!

[tanner0101]

I've updated tag 0.1.9 to include this commit.

[kylebshr]

This is strange — something in 0.1.9 is spitting out gibberish when the server starts. This didn't happen a few hours ago, but I don't think it was anything this PR added:

[artkay]

@kylebshr whoops sorry, I think that was me.
#34 will fix that once merged.