Skip to content

4.86.1 - Create a thread pool of System.coreCount rather than 64 when initializing an Application
Compare
Choose a tag to compare
@penny-for-vapor penny-for-vapor released this 07 Nov 06:39
· 49 commits to main since this release
4.86.1
1d075c8
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

What's Changed

Create a thread pool of System.coreCount rather than 64 when initializing an Application by @dfed in #3092

Following this recommendation, this PR simply changes the default number of cores when initializing an Application from 64 to the current number of cores.

This means that initializing an Application with default arguments now spins up 2x the number of threads as cores on device. We’ll create System.coreCount threads when instantiating the threadPool, and another System.coreCount threads when we instantiate the eventLoopGroup.

2x System.coreCount is still way better than System.coreCount + 64 on older devices, so while this PR does not directly address #3003, it does reduce total thread usage on init.

New Contributor

  • @dfed made their first contribution in #3092 🎉
This patch was released by @gwynne

Full Changelog: 4.86.0...4.86.1

Contributors

dfed and gwynne
Assets 2